Add public key hash check in Signed Note verification #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojoungjang
changed the title
hojoungjang
force-pushed
the
hojoungjang/issue-389
branch
from
edc0d86
to
0b79384
Compare
Signed-off-by: Jang <[email protected]>
Update existing tests and ensure they work as expected and add a unit test case to check for public key mismatch. Signed-off-by: Jang <[email protected]>
hojoungjang
force-pushed
the
hojoungjang/issue-389
branch
from
0b79384
to
97d9e08
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
===========================================
- Coverage 66.46% 51.44% -15.02%
===========================================
Files 92 189 +97
Lines 9258 19478 +10220
===========================================
+ Hits 6153 10021 +3868
- Misses 2359 8378 +6019
- Partials 746 1079 +333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jang <[email protected]>
|
@haydentherapper Thanks! I have addressed your comment. |
|
Thanks for the review. I will leave this as it is for now since I don't have the permission to merge. Please let me know if there is anything I can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a public key hash check in
SignedNote.Verifymethod.The hash stored in
note.Signatureis compared against the verifier's public key hash. If the hash mismatches, the verification fails.Release Note
SignedNote.Signis updated to useGetPublicKeyHashfunction.GetPublicKeyHashis added to calculate sha256 hash of the input public key (copied the existing logic inSignedNote.Signmethod)SignedNote.Verifyis updated to compare hash stored innote.Signatureis and the verifier's public key hash.Documentation