Add error message when computing consistency proof (#2278)

The service would panic if firstSize > lastSize because the error object was not created. Signed-off-by: Hayden Blauzvern <[email protected]>
sigstore · Nov 19, 2024 · 56ea4b5 · 56ea4b5
1 parent 3eb84f9
commit 56ea4b5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/api/tlog.go b/pkg/api/tlog.go
@@ -123,7 +123,8 @@ func stringPointer(s string) *string {
 // GetLogProofHandler returns information required to compute a consistency proof between two snapshots of log
 func GetLogProofHandler(params tlog.GetLogProofParams) middleware.Responder {
 	if *params.FirstSize > params.LastSize {
-		return handleRekorAPIError(params, http.StatusBadRequest, nil, fmt.Sprintf(firstSizeLessThanLastSize, *params.FirstSize, params.LastSize))
+		errMsg := fmt.Sprintf(firstSizeLessThanLastSize, *params.FirstSize, params.LastSize)
+		return handleRekorAPIError(params, http.StatusBadRequest, fmt.Errorf("consistency proof: %s", errMsg), errMsg)
 	}
 	tc := trillianclient.NewTrillianClient(params.HTTPRequest.Context(), api.logClient, api.logID)
 	if treeID := swag.StringValue(params.TreeID); treeID != "" {