-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML tag extensions #547
YAML tag extensions #547
Conversation
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
a9db28f
to
a86a588
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
- Coverage 64.02% 63.05% -0.97%
==========================================
Files 4 17 +13
Lines 303 1302 +999
==========================================
+ Hits 194 821 +627
- Misses 78 405 +327
- Partials 31 76 +45 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
a86a588
to
ed21107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, but you might want to still keep the ones in identity.go
in case we might want to parse those from yaml?
Signed-off-by: linus-sun <[email protected]>
ed21107
to
239855a
Compare
Summary
Small PR to add YAML tagging to the OIDExtensions struct so that they are properly parsed by the rekor-monitor reusable monitoring workflow and added to the MonitoredValues struct from the ConfigMonitoredValues struct. As the MonitoredValues struct is no longer being parsed into, the YAML tags for it have been removed in favor of ConfigMonitoredValues.
Release Note
NONE
Documentation
N/A