Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML tag extensions #547

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

linus-sun
Copy link
Collaborator

@linus-sun linus-sun commented Nov 19, 2024

Summary

Small PR to add YAML tagging to the OIDExtensions struct so that they are properly parsed by the rekor-monitor reusable monitoring workflow and added to the MonitoredValues struct from the ConfigMonitoredValues struct. As the MonitoredValues struct is no longer being parsed into, the YAML tags for it have been removed in favor of ConfigMonitoredValues.

Release Note

NONE

Documentation

N/A

@linus-sun linus-sun force-pushed the linussun/yaml-tag-extensions branch from a9db28f to a86a588 Compare November 19, 2024 22:36
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.05%. Comparing base (d271ec7) to head (239855a).
Report is 171 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   64.02%   63.05%   -0.97%     
==========================================
  Files           4       17      +13     
  Lines         303     1302     +999     
==========================================
+ Hits          194      821     +627     
- Misses         78      405     +327     
- Partials       31       76      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@linus-sun linus-sun force-pushed the linussun/yaml-tag-extensions branch from a86a588 to ed21107 Compare November 19, 2024 22:43
@linus-sun linus-sun marked this pull request as ready for review November 19, 2024 22:55
mihaimaruseac
mihaimaruseac previously approved these changes Nov 19, 2024
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, but you might want to still keep the ones in identity.go in case we might want to parse those from yaml?

Signed-off-by: linus-sun <[email protected]>
@haydentherapper haydentherapper merged commit 6c2f5c8 into sigstore:main Nov 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants