Implement certificate transparency monitoring reusable workflow and update documentation #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 64.02% 57.73% -6.29%
==========================================
Files 4 18 +14
Lines 303 1486 +1183
==========================================
+ Hits 194 858 +664
- Misses 78 544 +466
- Partials 31 84 +53 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
linus-sun
force-pushed
the
linussun/ct-workflow-file
branch
2 times, most recently
from
263721b to
3fb765b
Compare
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
linus-sun
force-pushed
the
linussun/ct-workflow-file
branch
from
3fb765b to
80ab154
Compare
| contents: read | ||
|
|
||
| env: | ||
| UPLOADED_LOG_NAME: checkpoint |
There was a problem hiding this comment.
We need to update the env var names based on the new defaults, correct?
README.md
Outdated
| - certSubject: https://github\.com/actions/starter-workflows/blob/main/\.github/workflows/lint\.yaml@.* | ||
| issuers: | ||
| - https://token\.actions\.githubusercontent\.com | ||
| subjects: |
There was a problem hiding this comment.
Remove example of subjects and fingerprints?
linus-sun
force-pushed
the
linussun/ct-workflow-file
branch
from
80ab154 to
27cf0a8
Compare
| @@ -40,8 +40,8 @@ permissions: | |||
| contents: read | |||
|
|
|||
| env: | |||
| UPLOADED_LOG_NAME: checkpoint | |||
| LOG_FILE: checkpoint_log.txt | |||
| UPLOADED_LOG_NAME: ct_checkpoint | |||
There was a problem hiding this comment.
whoops, I think we flipped these! These should remain the same, and we should change the other.
linus-sun
force-pushed
the
linussun/ct-workflow-file
branch
from
27cf0a8 to
3729b36
Compare
Co-authored-by: Hayden B <[email protected]> Signed-off-by: Linus Sun <[email protected]> Signed-off-by: linus-sun <[email protected]>
linus-sun
force-pushed
the
linussun/ct-workflow-file
branch
from
3729b36 to
d94d8d7
Compare
haydentherapper
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per changes outlined in this doc, this PR implements the certificate transparency monitoring reusable workflow file, runnable via GitHub Actions, and updates the README to demonstrate how to run the reusable certificate transparency monitoring workflow.
Release Note
Certificate transparency logs have become monitorable via the
ct_reusable_monitoring.ymlworkflowDocumentation
README is updated to reflect how to use the
ct_reusable_monitoringworkflow