Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for finding subjects in certificate transparency logs #514

Merged

Conversation

linus-sun
Copy link
Collaborator

@linus-sun linus-sun commented Oct 30, 2024

Summary

This PR, per work outlined here, begins implementation of supporting identity monitoring within certificate transparency logs by adding support for monitoring subjects within a certificate in a certificate transparency log's entry. Functionality is tested via unit testing.

Release Note

NONE

Documentation

N/A

pkg/ct/monitor_test.go Outdated Show resolved Hide resolved
@linus-sun linus-sun force-pushed the linussun/run-fulcio-id-monitor branch from d80b1c0 to beeaaae Compare October 30, 2024 20:20
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 61.93%. Comparing base (d271ec7) to head (f3e7f7f).
Report is 150 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ct/test_utils.go 28.57% 8 Missing and 2 partials ⚠️
pkg/ct/monitor.go 59.09% 8 Missing and 1 partial ⚠️
pkg/util/file/file.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
- Coverage   64.02%   61.93%   -2.09%     
==========================================
  Files           4       17      +13     
  Lines         303     1248     +945     
==========================================
+ Hits          194      773     +579     
- Misses         78      400     +322     
- Partials       31       75      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linus-sun linus-sun force-pushed the linussun/run-fulcio-id-monitor branch from beeaaae to 005c754 Compare October 30, 2024 20:26
@linus-sun linus-sun marked this pull request as ready for review October 30, 2024 20:35
@linus-sun linus-sun requested review from haydentherapper and mihaimaruseac and removed request for haydentherapper October 30, 2024 20:35
pkg/ct/monitor_test.go Outdated Show resolved Hide resolved
pkg/identity/identity.go Show resolved Hide resolved
pkg/ct/monitor.go Show resolved Hide resolved
@linus-sun linus-sun force-pushed the linussun/run-fulcio-id-monitor branch 2 times, most recently from d6bbbf8 to 8f522d4 Compare October 31, 2024 19:36
@linus-sun linus-sun force-pushed the linussun/run-fulcio-id-monitor branch from 8f522d4 to f3e7f7f Compare October 31, 2024 20:03
@haydentherapper haydentherapper merged commit 48375db into sigstore:main Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants