-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor OIDMatcher into separate utils package #454
refactor OIDMatcher into separate utils package #454
Conversation
f78bed1
to
7112812
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 64.02% 58.29% -5.73%
==========================================
Files 4 7 +3
Lines 303 458 +155
==========================================
+ Hits 194 267 +73
- Misses 78 149 +71
- Partials 31 42 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but question on pkg/util/file/file.go and pkg/util/file/file_test.go as they seem unrelated: do we want them in this PR?
I believe they're referenced because I moved them out of the |
Just realized this duplicates the file utils, should be fixed |
5f9aac5
to
3b73e49
Compare
Signed-off-by: linus-sun <[email protected]>
3b73e49
to
8504b2f
Compare
Summary
This PR refactors the OIDMatcher type into a separate utils package, which will subsequently enable this PR to refactor the renderFulcioOIDMatchers function into a struct method (re: discussion here).
Release Note
NONE
Documentation
NONE- related documentation changes will happen in their respective PRs.