Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide cli containerfile #329

Merged
merged 3 commits into from
Dec 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions Containerfile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be named Dockerfile?

Also, can you add the standard license header please? (the one with sigstore authors, see https://github.com/sigstore/model-transparency/blob/main/src/model_signing/__init__.py)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mihaimaruseac, I added the license header. 😃
Regarding the file, I named it Containerfile over Dockerfile since its agnostic to container engines like Podman, Buildah (got recently donated to CNCF) or Docker. Podman/Buildah seem to pick Containerfile over Dockerfile by default. We could still change it if you think it makes more sense - wdyt? :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the context! This makes a lot of sense (and TIL!)

Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Copyright 2024 The Sigstore Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""For the stable high-level API, see model_signing.api."""

__version__ = "0.1.1"

FROM python:3.13-slim

COPY pyproject.toml ./
COPY src ./src

RUN python -m pip install model_signing

RUN echo '#!/bin/bash\n\
cd "/src" && python sign.py' > /usr/local/bin/sign

RUN echo '#!/bin/bash\n\
cd "/src" && python verify.py' > /usr/local/bin/verify

RUN echo '#!/bin/bash\n\
echo "Usage:"\n\
echo " verify - Runs the verify.py Python script"\n\
echo " sign - Runs the sign.py Python script"\n\
echo " help - Displays this help message"' > /usr/local/bin/help

RUN chmod +x /usr/local/bin/sign /usr/local/bin/verify /usr/local/bin/help

CMD ["help"]

Loading