add sigstore signing integration test #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could also be moved to the higher API level now that #323 is merged |
+1, let's migrate both this and the benchmarks to the higher level API |
|
I'll note there is a lot of variance in runtime depending on the GitHub action scheduling in the conformance repo, I've seen anything from 4s to 3m. So we could have this as a check on every PR (maybe not required?), or set it up on a schedule. |
By default `hatch test` wont run integration tests, but they can be run with `hatch test -m integration`. Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
commented
Nov 26, 2024
Comment on lines
+37
to
+39
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| python-version: ['3.10', '3.11', '3.12', '3.13'] |
There was a problem hiding this comment.
can make this a smaller matrix if desired (currently 12 signing + verifying events per PR update), I know we talked about other OS test properties that may need to be manual. (sign on linux, verify on windows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the addition of #319, we can test OIDC signing more easily using Sigstore's extremely dangerous public OIDC beacon.
This is the first integration tests and relates to #5. The change is written such that
hatch testwill continue to only run unit tests. Devs and CI jobs that want to run the integration tests need to use theintegrationmarker:I'm still playing with the test, particularly around handling of expired tokens.
Release Note
NONE
Documentation