Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #1331, fix memory leaks, support Volts/div units, sort channels by type, do not show all read capabilities, parse SCPI commands #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gtrentalancia
Copy link
Contributor

@gtrentalancia gtrentalancia commented Nov 18, 2018

main.c | 15 +++++++++++++++
parsers.c | 10 +++++++++-
show.c | 53 ++++++++++++++++++++++++++++++++++++++++-------------
sigrok-cli.h | 3 +++
4 files changed, 67 insertions(+), 14 deletions(-)

@gtrentalancia gtrentalancia changed the title Fix bug #1331 and a couple of memory leaks Fix bug #1331, fix memory leaks, support Volts/div units Nov 21, 2018
@gtrentalancia gtrentalancia changed the title Fix bug #1331, fix memory leaks, support Volts/div units Fix bug #1331, fix memory leaks, support Volts/div units, sort channels by type Dec 13, 2018
@gtrentalancia gtrentalancia changed the title Fix bug #1331, fix memory leaks, support Volts/div units, sort channels by type Fix bug #1331, fix memory leaks, support Volts/div units, sort channels by type, do not show all read capabilities Dec 16, 2018
@gtrentalancia gtrentalancia changed the title Fix bug #1331, fix memory leaks, support Volts/div units, sort channels by type, do not show all read capabilities Fix bug #1331, fix memory leaks, support Volts/div units, sort channels by type, do not show all read capabilities, parse SCPI commands Dec 21, 2018
broken in sigrok-cli (invalid values are displayed):

- "timebase" in yokogawa-dlm, rohde-schwarz-hameg, hantek-dso,
  lecroy-xstream, siglent-sds and rigol-ds drivers;
- "vdiv" in hantek-6xxx, yokogawa-dlm, rohde-schwarz-hameg,
  hantek-dso, lecroy-xstream, hung-chang-dso-2100, siglent-sds and rigol-ds drivers;
- "spl_meas_range" in pce-322a and cem-dt-885x drivers.

Fixes bug #1331.
For example, automatic measurements can be read but should not
be shown in the supported configuration options list (--show).

This change requires the following recent libsigrok change:

commit 7b68fbf0671c9865984333327f215384f7e8b197
Date:   Thu Dec 20 19:51:11 2018 +0100
The support for sending custom SCPI commands to the device
has recently been added to libsigrok.

Add the corresponding support for parsing such commands in
sigrok-cli.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants