OLS cleanups #84
Closed
OLS cleanups #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's nowhere documented and nowhere used.
…ure. This is a preparation to introduce "device flags" later that describe the device itself, not a specific operation.
Draft
|
I can pick up these improvements. @wsakernel shall I add your Acked-By? |
|
Technically, it would be more Reviewed-by. But I don't mind much which one... Thanks! |
|
Merged in 6f9234e, thank you. Have added wsa's Reviewed-By. Had to adjust the commit messages. Would be nice if your future commits would stick with the project's habit of prefixing the subject with the driver name. Makes it easier to navigate later during research. |
|
@gsigh: Sure, will do! Thanks for telling me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These clean-ups are taken from #51 and are the base to further refactor the driver and add support for advanced features of the DemonCore.