-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for file field in Drupalgap #825
base: 7.x-1.x
Are you sure you want to change the base?
Conversation
@luxio Awesome video! You've done some great things here. I am reviewing this now. Initial recommendation would be, it looks like we'll want to leave the binaries out of the pull request, and only commit the |
if (element.field_info_field && | ||
element.field_info_field.cardinality == -1) { | ||
var add_another_item_variables = { | ||
text: 'Add another item', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luxio Please wrap this in a t(), text: t('Add another item')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@luxio Looks great, very nice work. Is this in any ways tied to how the Media module is operating in Drupal, or is this independent of it and only for DrupalGap Core Files/Images ? |
Thanks for the Feedback.
It is independent of the media module. |
dpm(s[0]); | ||
var mediaHTML = "<video style='max-width:100%;' controls><source src='" + s[0].fullPath + "'></video>"; | ||
$("#" + input_id + "-media").html(mediaHTML); | ||
uploadFile(s[0].fullPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my current work on uploading (unlimited) media files in Drupal Gap using the raw file services resource.
It is not ready yet, but I'm interested in your feedback to this approach.
Here is short demo: