Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add directory of the collection to SigMFCollection #85

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add directory of the collection to SigMFCollection #85

wants to merge 7 commits into from

Conversation

GreenK173
Copy link

Solves #84 by adding an optional parameter collection_path to SigMFCollection which is the path to the directory where the collection lives. Plus an unit test.

@Teque5
Copy link
Collaborator

Teque5 commented Dec 14, 2024 •
edited
Loading

  1. Can you change this to use tempfile like how I did for PR#81 so it doesn't create stray files?
  2. Please rename the test to test_collection.py so we can put other tests in there.

After that I'll review in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreenK173 @Teque5