feat: implement image cache configuration #9768
Merged
+1,331
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
smira
force-pushed
the
feat/image-cache-configuration
branch
from
09555ac
to
11d246f
Compare
frezbo
reviewed
Nov 20, 2024
internal/app/machined/pkg/controllers/cri/image_cache_config.go
Outdated
Show resolved
Hide resolved
smira
force-pushed
the
feat/image-cache-configuration
branch
from
11d246f
to
554bc64
Compare
frezbo
reviewed
Nov 21, 2024
smira
force-pushed
the
feat/image-cache-configuration
branch
from
554bc64
to
66617b4
Compare
|
Example machine config patch to activate this feature: machine:
features:
imageCache: true
---
apiVersion: v1alpha1
kind: VolumeConfig
name: IMAGECACHE
provisioning:
diskSelector:
match: disk.transport == "nvme" && !system_disk |
Implement a feature flag, a resource which controls the flow. This controls the volume configuration, mounting, etc. Fixes siderolabs#9767 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/image-cache-configuration
branch
from
66617b4
to
5f68c17
Compare
# talosctl -n 172.20.0.5 get imagecacheconfig -o yaml
node: 172.20.0.5
metadata:
namespace: cri
type: ImageCacheConfigs.cri.talos.dev
id: image-cache
version: 4
owner: cri.ImageCacheConfigController
phase: running
created: 2024-11-21T17:21:14Z
updated: 2024-11-21T17:21:17Z
spec:
status: ready
roots:
- /system/imagecache/disk |
|
|
/m |
machine:
features:
imageCache: trueseems this patch needs a reboot, I guess that was not intended 🤔 |
ah, true, I'll get it fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a feature flag, a resource which controls the flow.
This controls the volume configuration, mounting, etc.
Fixes #9767