-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#673): migrate to AuthJS #924
base: main
Are you sure you want to change the base?
Conversation
commit: |
// This header is set to force AuthJS to return JSON | ||
// https://github.com/nextauthjs/next-auth/blob/b86f7bb721e2fa4e9c3251b029095b0f50d46198/packages/next-auth/src/react.tsx#L270-L285 | ||
// https://github.com/nextauthjs/next-auth/blob/b86f7bb721e2fa4e9c3251b029095b0f50d46198/packages/core/src/index.ts#L160 | ||
'X-Auth-Return-Redirect': '1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new header which needs to be documented (or linked to authjs
docs). We need to mention for users to add it to their header whitelists
While testing the code in a private project, we unfortunately discovered that AuthJS itself errors on an existing codebase. Setting up a new project with the official Next starter results in the same error. After an in-depth investigation, the issue lies with their new dependency |
Hello there! Thanks you very much for letting us aware of the ongoing work. From what I read, should I understand that the migration is now working for those not using a database? IE, we're using third party provider, aka keycloak. Should I expect the latest version to work as expected? If so, which version can I give a try? |
Sorry for a misleading comment, I meant codebase π¨ The migration is simply not working - as stated, the issue is not on our side, but on the |
Hello @phoenix-ru! Thanks for working on this! Would it be possible to add a reference to the next issue? |
Hi @kogratte I may get back to it today if I have some time. We deprioritized the migration because we lost trust in |
π Linked issue
#673
β Type of change
π Description
π Checklist