-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for custom refresh handling #715
feat: Add support for custom refresh handling #715
Conversation
Hi @blumewas π Have you had a chance to look at the review yet? Otherwise are there any other open questions I can help you with? |
Hi @zoey-kaiser, |
Hey @zoey-kaiser, |
Hi @blumewas π Thank you so much, sadly the lint is currently failing. However, its just an extra console statement and unneeded semi column. We can already begin on another review, but we will need to wait to merge until the linter passes π |
Sorry my bad π I have now removed the console statement which made the linter fail |
Thanks for the PR :) I noticed that it's missing the website documentation, but I also checked Would you be able to copy your options to the doc or should we do that ourselves? |
I can do that later today. If you want to merge it already then it would be better if you will do it π |
π Linked issue
Issue #714
β Type of change
π Description
The current behaviour for refreshing the users tokens does not provide many options for me as developer. As a developer I would like to be able to extend or customize this behaviour.
This PR:
RefreshHandler
andRefreshHandlerConfig
RefreshHandler
viarefreshHandler?
property toauth.session
π Checklist