-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added proc-macro-error2 dependency #1921
base: main
Are you sure you want to change the base?
added proc-macro-error2 dependency #1921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Here's my concise review of the changes:
Updated proc-macro error handling in shuttle-codegen to address security concerns by replacing unmaintained dependencies.
- Replaced
proc-macro-error
withproc-macro-error2
v2.0.1 in/codegen/Cargo.toml
to resolve RUSTSEC-2024-0370 advisory - Updated macro import in
/codegen/src/lib.rs
fromproc_macro_error
toproc_macro_error2::proc_macro_error
- Maintained API compatibility with existing error handling while using actively maintained dependency
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
codegen/Cargo.toml
Outdated
@@ -10,7 +10,7 @@ description = "Proc-macro code generator for the shuttle.rs service" | |||
proc-macro = true | |||
|
|||
[dependencies] | |||
proc-macro-error = "1.0.4" | |||
proc-macro-error2 = "2.0.1" | |||
proc-macro2 = "1.0.47" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: proc-macro2 version 1.0.47 is quite old, consider updating to latest 1.0.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonaro00 , please review the pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
No major changes found since last review. The previous review already covered the key changes regarding the proc-macro dependency updates and their implications.
The changes remain focused on:
- Replacing unmaintained
proc-macro-error
withproc-macro-error2
- Updating
proc-macro2
version - Maintaining API compatibility
No additional review points needed as the core changes were thoroughly covered in the previous review.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
closes #1873
Summary
Added
proc-macro-error-2
and removedproc-macro-error
dependency.