Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement common traits #34

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

implement common traits #34

wants to merge 4 commits into from

Conversation

YeungOnion
Copy link

  • feat: impl Hash for BPlusTree
  • feat: derive Debug
  • feat: impl Default for BPlusTree using vec backed node store
  • feat: impl PartialEq for BPlusTree

@YeungOnion
Copy link
Author

YeungOnion commented Aug 25, 2024 •
edited
Loading

questions I have for now are,

  • what do you think of Hash and PartialEq?
  • should I drop the intent to implement Display since std::collections BTree doesn't? decided against this
  • what should I write tests for? Perhaps testing that Hash is different for tuples that don't have prefix collisions?

@YeungOnion YeungOnion marked this pull request as ready for review August 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YeungOnion