Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WhatsApp Card in the Integrations Workspace #93

Closed
wants to merge 11 commits into from

Conversation

buff0k
Copy link
Contributor

@buff0k buff0k commented Aug 16, 2024

This will create a Link Card in the Integrations Workspace for WhatsApp after installation, as well as remove same before uninstall.

buff0k added 8 commits August 16, 2024 15:50
Create Workspace Card under Integrations
Remove WhatsApp Integrations Card on uninstall
Added hooks to automate adding a Link Card to Integrations
Create Link Card in Integrations Workspace for Frappe WhatsApp
Remove WhatsApp Integrations Card before uninstall
buff0k added 3 commits August 19, 2024 13:24
Move function to after migrate
Re-add after_install hook to also work on new installations (existing sanity check will avoid duplication)
@shridarpatil
Copy link
Owner

image

Copy link

@devdiogenes devdiogenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code gets errors if already exists. To fix it, I suggest you put if card_exists: return, instead

image

Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants