Skip to content

Commit

Permalink
SHOT-4386: Update min supported logic to avoid dialog pop up (#124)
Browse files Browse the repository at this point in the history
  • Loading branch information
staceyoue authored Sep 6, 2024
1 parent f34f174 commit 4832922
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,11 @@ def pre_app_init(self):

# check for version compatibility
self.vred_version = os.getenv("TK_VRED_VERSION", None)
vred_major_version = self.vred_version[:4]
self.logger.debug("Running VRED version {}".format(self.vred_version))
if (
self._version_check(
self.vred_version,
vred_major_version,
str(self.get_setting("compatibility_dialog_min_version")),
)
> 0
Expand All @@ -160,7 +161,7 @@ def pre_app_init(self):
"Warning - Flow Production Tracking Toolkit!",
msg,
)
elif self._version_check(self.vred_version, "2021.0") < 0 and self.get_setting(
elif self._version_check(vred_major_version, "2021.0") < 0 and self.get_setting(
"compatibility_dialog_old_version"
):
msg = (
Expand Down
2 changes: 1 addition & 1 deletion info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ configuration:
description: "Specify the minimum Application major version that will prompt a warning if
it isn't yet fully supported and tested with Toolkit. To disable the warning
dialog for the version you are testing, it is recommended that you set this
value to the current major version + 1."
value to the latest supported version."
default_value: 2025

compatibility_dialog_old_version:
Expand Down

0 comments on commit 4832922

Please sign in to comment.