Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHOT-4404: Performance #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

SHOT-4404: Performance #74

wants to merge 5 commits into from

Conversation

staceyoue
Copy link
Contributor

  • Currently performance is impacted because Qt QML refreshes after every Alias API request
  • With this change, we invoke batch requests in a single Qt event so that QML is only refreshed once after all requests have executed (prevents the UI from updating during multiple API calls)

@staceyoue
No need to return a value, exception raised on failure.
4fce7b1
@staceyoue
Modify create_wrapper method to allow any data type and the onus is o…
3035015 
…n the subclass to determine what data type is allowed. This allows list values to be processed.
@staceyoue
Remove unused function _create. Update validate function doc.
f2f044a
@staceyoue
Add AliasApiRequestListWrapper class for lists of api requests.
9a18585
@staceyoue
Handle multipe api requests in single Qt event
91e8521 
* Execute multiple Alias API requests in a single Qt event
* Batch requests are contained in an AliasApiRequestListWrapper, which
  ensures that all Alias API requests are invoked in one Qt event
* This improves performance greatly because it means that Qt UI does not
  refresh after every Alias API call, instead all API calls are executed
  and Qt refreshes once after they are done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@staceyoue