-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign #65
base: main
Are you sure you want to change the base?
Redesign #65
Conversation
Will backport the theme to Hugo 0.111.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the process for upgrading to a new version of Hextra?
Is there a preview we could see, or at least a screenshot?
I'm maintaining a branch with the backport patches: https://github.com/pka/hextra/tree/backport-debian Hugo docs recommend including a theme as git submodule. We could do that for simplifying updates. But not anybody likes working with submodules... |
A subtree is apparently easier to manage |
…d-website/themes/hextra'
git-subtree-dir: shortbread-website/themes/hextra git-subtree-split: ce3b99532a2b31273852f76c6b4ee8376734a6a1
In response to the overwelming enthusiasm, I've cleaned up the commits and added the hextra theme as subtree, to make it ready for merge. |
|
I don't understand why you need to backport a theme. It is just a bunch of CSS files and icons isn't it? Anyway. Looks okay to me, certainly better than what we had before. |
The theme uses built-in Hugo functions ( |
My plan was to have this ready for SotM. Does anyone plan a review, or is it ok to merge? |
…444d9 ca444d9 Replace path.Join with printf git-subtree-dir: shortbread-website/themes/hextra git-subtree-split: ca444d974c56303bf772f9143651e3bcd2dd19da
I'll have a talk about Shortbread at FOSS4G in a month and would like to show the website in the new look. Would that be a motivation for reviewing and/or merging? |
For my taste the condensed font is hard to read and the line-height leaves a lot of white-space. Other than that I am happy with the design. Its okay for me to go with this. Something gets pulled in from gstatic.com, that should be fixed. |
I see your point, but at least it makes Shortbread really short!
Fonts are now included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for me.
I've changed the Hugo theme to Hextra and adapted it inspired by the Reveal solarized theme.
I hope you like it, @amandasaurus!