Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #65

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Redesign #65

wants to merge 8 commits into from

Conversation

pka
Copy link
Member

@pka pka commented Sep 2, 2024

I've changed the Hugo theme to Hextra and adapted it inspired by the Reveal solarized theme.

I hope you like it, @amandasaurus!

@pka
Copy link
Member Author

pka commented Sep 2, 2024

Will backport the theme to Hugo 0.111.3.

@pka pka marked this pull request as draft September 2, 2024 23:39
@pka pka marked this pull request as ready for review September 3, 2024 08:20
Copy link
Contributor

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process for upgrading to a new version of Hextra?

Is there a preview we could see, or at least a screenshot?

shortbread-website/content/_index.md Outdated Show resolved Hide resolved
@pka
Copy link
Member Author

pka commented Sep 4, 2024

screenshot-2024-09-04-07-25-05

screenshot-2024-09-04-07-24-21

On small screens, only one column is shown.

@pka
Copy link
Member Author

pka commented Sep 4, 2024

What's the process for upgrading to a new version of Hextra?

I'm maintaining a branch with the backport patches: https://github.com/pka/hextra/tree/backport-debian

Hugo docs recommend including a theme as git submodule. We could do that for simplifying updates. But not anybody likes working with submodules...

@pnorman
Copy link
Contributor

pnorman commented Sep 4, 2024

Hugo docs recommend including a theme as git submodule. We could do that for simplifying updates. But not anybody likes working with submodules...

A subtree is apparently easier to manage

git-subtree-dir: shortbread-website/themes/hextra
git-subtree-split: ce3b99532a2b31273852f76c6b4ee8376734a6a1
@pka
Copy link
Member Author

pka commented Sep 4, 2024

In response to the overwelming enthusiasm, I've cleaned up the commits and added the hextra theme as subtree, to make it ready for merge.

@pka
Copy link
Member Author

pka commented Sep 4, 2024

Oops, I just force-pushed accidently to main, will try to cleanup the mess...
It was just the main branch of my fork...

@joto
Copy link
Contributor

joto commented Sep 5, 2024

I don't understand why you need to backport a theme. It is just a bunch of CSS files and icons isn't it?

Anyway. Looks okay to me, certainly better than what we had before.

@pka
Copy link
Member Author

pka commented Sep 5, 2024

I don't understand why you need to backport a theme. It is just a bunch of CSS files and icons isn't it?

The theme uses built-in Hugo functions (hugo.IsMultiLingual and urls.JoinPath), which are not availabe in 0.111.

@pka
Copy link
Member Author

pka commented Sep 6, 2024

My plan was to have this ready for SotM. Does anyone plan a review, or is it ok to merge?

@pnorman pnorman self-requested a review September 8, 2024 03:46
…444d9

ca444d9 Replace path.Join with printf

git-subtree-dir: shortbread-website/themes/hextra
git-subtree-split: ca444d974c56303bf772f9143651e3bcd2dd19da
@pka
Copy link
Member Author

pka commented Nov 1, 2024

I'll have a talk about Shortbread at FOSS4G in a month and would like to show the website in the new look. Would that be a motivation for reviewing and/or merging?

@joto
Copy link
Contributor

joto commented Nov 1, 2024

For my taste the condensed font is hard to read and the line-height leaves a lot of white-space. Other than that I am happy with the design. Its okay for me to go with this.

Something gets pulled in from gstatic.com, that should be fixed.

@pka
Copy link
Member Author

pka commented Nov 4, 2024

For my taste the condensed font is hard to read and the line-height leaves a lot of white-space. Other than that I am happy with the design. Its okay for me to go with this.

I see your point, but at least it makes Shortbread really short!

Something gets pulled in from gstatic.com, that should be fixed.

Fonts are now included.

Copy link
Contributor

@joto joto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants