Skip to content

Commit

Permalink
docs: add note about flutter-version (#9)
Browse files Browse the repository at this point in the history
* docs: add note about flutter-version

* update workflow

* temp change to diagnose build failure

* fix build
  • Loading branch information
bryanoltman authored Mar 22, 2024
1 parent f80031b commit 237ec04
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ jobs:
- name: 🎯 Set up Flutter
uses: subosito/flutter-action@v2
with:
# TODO(bryanoltman): remove flutter-version specification once we
# support 3.19.4. This was added because `flutter create` creates a
# flutter project that requires a higher minimum Dart version than
# what we support.
flutter-version: "3.19.3"
channel: stable
cache: true

Expand All @@ -41,7 +46,7 @@ jobs:
java-version: "17"

- name: 🐦 Setup Shorebird
uses: shorebirdtech/setup-shorebird@v0
uses: shorebirdtech/setup-shorebird@v1

- name: ✨ Create New Flutter Project
run: flutter create e2e_test --empty
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ steps:
The action takes the following inputs:
- `args`: Any arguments to pass to `shorebird release`.
- `args`: Any arguments to pass to `shorebird release`. For example, if you need
to use a specific version of Flutter, you can pass `--flutter-version=1.2.3`.
- Use an extra `--` to pass arguments to Flutter (e.g. `-- --dart-define=KEY=VALUE`)
- `platform`: Which platform to create a release for (e.g. `android` or `ios-alpha`)
- `working-directory`: Which directory to run `shorebird release` in.
Expand Down

0 comments on commit 237ec04

Please sign in to comment.