Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move packages to biome #1518

Merged
merged 12 commits into from
Dec 9, 2024
Merged

feat: move packages to biome #1518

merged 12 commits into from
Dec 9, 2024

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Dec 6, 2024

Description

Continuation of the refactor, all packages moved to biome.

command
pnpm lint (running also with the commit)

before:
Time: 34.382s

after
Time: 4.138s

this also moves typecheck to separate task, but linting and formatting are much quicker now

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Dec 9, 2024 11:50am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Dec 9, 2024 11:50am

Copy link

pkg-pr-new bot commented Dec 6, 2024

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1518

@shopware-pwa/cms-base

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1518

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1518

@shopware-pwa/composables-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1518

@shopware-pwa/helpers-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1518

@shopware-pwa/nuxt3-module

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1518

commit: 7915986

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #1518 will not alter performance

Comparing feat/move-packages-to-biome (7915986) with main (fbc0033)

Summary

✅ 9 untouched benchmarks

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

442 changes, what a feat,
Every test passed, isn’t that neat?
Your code’s a marvel, a shining light,
This PR’s future is looking bright! 🚀

image

@patzick patzick merged commit 87610c0 into main Dec 9, 2024
13 checks passed
@patzick patzick deleted the feat/move-packages-to-biome branch December 9, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants