Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-client): add accountType and vatIds properties to changeProfile operation #1477

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

bounoable
Copy link
Contributor

This change introduces the accountType property to specify whether a customer is a private individual or a business. Additionally, the vatIds property is added to store VAT IDs for business accounts.

…eProfile` operation

This change introduces the accountType property to specify whether a customer
is a private individual or a business. Additionally, the vatIds property is
added to store VAT IDs for business accounts.
Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Dec 4, 2024 3:25pm

@patzick
Copy link
Collaborator

patzick commented Nov 26, 2024

thank you @bounoable for pointing out this problem. The json file is generated from the API, so we need to fix it at the source, otherwise it would be overwritten with the next generation. We can now patch this in our schema as well until the shopware/shopware#5680 is not merged and released

Copy link

pkg-pr-new bot commented Dec 4, 2024

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1477

@shopware-pwa/cms-base

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1477

@shopware-pwa/composables-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1477

@shopware-pwa/helpers-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1477

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1477

@shopware-pwa/nuxt3-module

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1477

commit: 8d5fa7f

Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #1477 will not alter performance

Comparing bounoable:main (8d5fa7f) with main (a87bbcf)

Summary

✅ 9 untouched benchmarks

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added patches for now so we'll have it properly in schema until the new API release 🙌

@patzick patzick merged commit fbc0033 into shopware:main Dec 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants