Skip to content

Commit

Permalink
Made release failures easier to recover
Browse files Browse the repository at this point in the history
Currently, it is difficult to recover from failures when the release step fails. For example, we have accidentally published 1.0.0 version some time ago (more info: #51). Now it is not possible to delete this version.

This change reorders the release steps: *first* we tag and release on GitHub (easy to revert), *then* we publish to Gradle plugins portal (harder to revert). 

This change prevents problems like #51 and makes them easier to recover from.
  • Loading branch information
mockitoguy authored Dec 13, 2020
1 parent 6ab8525 commit e1058a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
&& github.ref == 'refs/heads/master'
&& github.repository == 'shipkit/shipkit-changelog'
&& !contains(toJSON(github.event.commits.*.message), '[skip release]')
run: ./gradlew publishPlugins githubRelease --scan
run: ./gradlew githubRelease publishPlugins --scan
env:
# Gradle env variables docs: https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_environment_variables
GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }}
Expand Down

0 comments on commit e1058a7

Please sign in to comment.