Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image with publication #174

Open
wants to merge 5 commits into
base: source
Choose a base branch
from

Conversation

siddhu001
Copy link
Collaborator

Added an image along with OWSM publication information.
Still need to fix links of Project Page (i.e. Blog) and Demo

@ftshijt
Copy link
Contributor

ftshijt commented Oct 17, 2023

I may misunderstand, but it seems that the change is related to the HTML instead of the template. If in that case, the code will be swoop out during the page publication. Please consider change the template of the codebase instead of index.html

In short, change
https://github.com/shinjiwlab/shinjiwlab.github.io/blob/source/_layouts/bib.html
instead of https://github.com/shinjiwlab/shinjiwlab.github.io/tree/source/_site/publications

Sorry that if I'm misunderstanding the PR, please clarify a bit to me if you have other notes to that.

@siddhu001 siddhu001 marked this pull request as ready for review November 10, 2023 20:03
@siddhu001 siddhu001 requested a review from ftshijt November 10, 2023 20:03
@siddhu001
Copy link
Collaborator Author

Thanks I have fixed it!

@@ -136,6 +136,9 @@ @inproceedings{peng2023reproducing
booktitle=ASRU,
year={2023},
publisher={IEEE},
code={https://github.com/espnet/espnet},
blog={https://www.wavlab.org/activities/2023/foundations/},
img={../assets/img/blog/owsm_pipeline.png}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might forget to upload the images?

Btw, it might be better to create some directory structure for this activity (otherwise we might have a lot of images in one folder

@sw005320
Copy link
Contributor

Is it ready?
If so, I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants