Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What is the purpose of this pull request?
What changes did you make?
Add a switch to turn off involve
libm
. It will bring duplicate math function on Windows.libm
is special library, it is usually appeared on Linux, but we not use it on Windows.libm
for high performance purpose.Sleef
'sfind_library(libm m)
will involve thelibm
into project. So, we would occur the symbol conflict issue on math functions.My solution is add a switch(option) to let upper CMake project turn off
libm
involvement. It default value is on, and keep compatible to original logical.Does this PR relate to any existing issue?
Relates to/Fixes ([Intel GPU] Symbol conflict between libm.lib and ucrt.lib for Intel GPU on Windows)
Is there anything you would like reviewers to focus on?
Please on focus on...