features review #12
Open
features review #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getfutureproof-admin
requested review from
atheermusa,
shewitt93,
tashbeeh25 and
hannahtesfay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: DO NOT MERGE!
This is a great start, team! Running in the browser, it seems that the app is not quite functional yet, I cannot see the results rendered? I think on another go around, it would be well worth making decisions on the component structure and data flow early to avoid confusion at a later point.
There are some areas which are repetitive and could do with refinement and abstractions, this will come with time and experience!
Have a look at my comments and take them into consideration for a future refactor and/or future projects.
In preparation for our group retro at 1030 tomorrow, (Friday), consider the following: