Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests and other quality of life/code changes #4

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

sheriferson
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (be8d5f2) 55.74% compared to head (4cd65c8) 62.54%.

Files Patch % Lines
src/scrobble/app.py 0.00% 8 Missing ⚠️
src/scrobble/utils.py 69.23% 8 Missing ⚠️
src/scrobble/musicbrainz.py 83.33% 1 Missing ⚠️
src/scrobble/pushover.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   55.74%   62.54%   +6.80%     
==========================================
  Files           5        5              
  Lines         235      251      +16     
==========================================
+ Hits          131      157      +26     
+ Misses        104       94      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sheriferson sheriferson force-pushed the misc/improve-tests-and-misc branch from 6609cb0 to 4cd65c8 Compare January 22, 2024 03:24
@sheriferson sheriferson merged commit b34e7dc into main Jan 22, 2024
2 checks passed
@sheriferson sheriferson deleted the misc/improve-tests-and-misc branch January 22, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants