Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older VIM without syn iskeyword #816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vcargats
Copy link

syn iskeyword was added in 7.4.1142. This adds a fallback to 'setlocal iskeyword'.

@sheerun
Copy link
Owner

sheerun commented Oct 14, 2022

I'd suggest changing build script so syn is replaced by setlocal iskeyword in all files automatically during build

@vcargats
Copy link
Author

vcargats commented Oct 14, 2022

hm... I have checked other syntax files. It turns out that a half of those which use 'syn iskeyword' already have a fallback.

So these are that have the fallback:
blade.vim
mapple.vim
pgsql.vim
bicep.vim
hcl.vim
lisp.vim

And these are that don't have:
pf.vim
crystal.vim
html.vim
awk.vim
dune.vim
svelte.vim
mf.vim
debcontrol.vim
kabal.vim
tydy.vim

Now I can modify the build script and replace just the files that do not yet have the fallback.

Or I may create corresponding PRs for the original syntax files if their repos still exist/supported, so that new versions will be eventually pulled into this repo. css.vim for example is deprecated, so I think I need to change that here.

What do you think?

@sheerun
Copy link
Owner

sheerun commented Oct 14, 2022

Build script is the easiest way, but you can send PRs to other repos if you want it. I've just pushed updated build

@vcargats
Copy link
Author

Your latest commit does not have build script.
So you were going to replace that by yourself? I just didn't understand.

@sheerun
Copy link
Owner

sheerun commented Oct 15, 2022

No, go ahead. I meant it just as in "For your information"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants