Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits(?) & fixes #183

Merged
merged 35 commits into from
Nov 1, 2024
Merged

Edits(?) & fixes #183

merged 35 commits into from
Nov 1, 2024

Conversation

Yung-Beef
Copy link
Contributor

Probably missed a few things with typos and stuff but I think I got them all. I think there were a few changes that I'm not sure about, so please review.

steps/20/README.md Outdated Show resolved Hide resolved
steps/20/README.md Outdated Show resolved Hide resolved
steps/22/src/lib.rs Outdated Show resolved Hide resolved
steps/38/src/impls.rs Outdated Show resolved Hide resolved
steps/38/src/impls.rs Outdated Show resolved Hide resolved
steps/52/README.md Outdated Show resolved Hide resolved
@@ -2,6 +2,7 @@ use super::*;
use frame::prelude::*;
use frame::primitives::BlakeTwo256;
/* 🚧 TODO 🚧: Import `frame::traits::tokens::Preservation`. */
/* 🚧 TODO 🚧: Import `frame::traits::fungible::Mutate`. */
Copy link
Owner

@shawntabrizi shawntabrizi Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed since you have super::*, and lib.rs imports this already

steps/52/src/impls.rs Outdated Show resolved Hide resolved
steps/6/README.md Outdated Show resolved Hide resolved
Copy link
Owner

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catches

@shawntabrizi shawntabrizi merged commit a653ddc into shawntabrizi:master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants