-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits(?) & fixes #183
Merged
Merged
Edits(?) & fixes #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess this one will need to be copied to all of the future steps
id suddenly changes to dna in the next step with no mention of it
Couldn't create a kitty struct in tests.rs without making the struct fields public
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
reviewed
Nov 1, 2024
steps/52/src/impls.rs
Outdated
@@ -2,6 +2,7 @@ use super::*; | |||
use frame::prelude::*; | |||
use frame::primitives::BlakeTwo256; | |||
/* 🚧 TODO 🚧: Import `frame::traits::tokens::Preservation`. */ | |||
/* 🚧 TODO 🚧: Import `frame::traits::fungible::Mutate`. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed since you have super::*
, and lib.rs imports this already
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
reviewed
Nov 1, 2024
shawntabrizi
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably missed a few things with typos and stuff but I think I got them all. I think there were a few changes that I'm not sure about, so please review.