Merge pull request #444 from sharetribe/block-id-optional

Make Block's propType blockId optional
sharetribe · Sep 2, 2024 · 0acab36 · 0acab36
2 parents 8b81bf0 + 53663b2
commit 0acab36
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ way to update this template, but currently, we follow a pattern:
 
 ## Upcoming version 2024-XX-XX
 
+- [change] Make the propType blockId optional for all Block types. [#444](https://github.com/sharetribe/web-template/pull/444)
 - [change] Updates to the configuration script. Marketplace name is now prompted in the mandatory
   settings. [#440](https://github.com/sharetribe/web-template/pull/440)
 - [change] Update one copy text. [#439](https://github.com/sharetribe/web-template/pull/439)

diff --git a/src/containers/PageBuilder/BlockBuilder/BlockDefault/BlockDefault.js b/src/containers/PageBuilder/BlockBuilder/BlockDefault/BlockDefault.js
@@ -73,7 +73,7 @@ BlockDefault.defaultProps = {
 };
 
 BlockDefault.propTypes = {
-  blockId: string.isRequired,
+  blockId: string,
   className: string,
   rootClassName: string,
   mediaClassName: string,

diff --git a/src/containers/PageBuilder/BlockBuilder/BlockFooter/BlockFooter.js b/src/containers/PageBuilder/BlockBuilder/BlockFooter/BlockFooter.js
@@ -36,7 +36,7 @@ BlockFooter.defaultProps = {
 };
 
 BlockFooter.propTypes = {
-  blockId: string.isRequired,
+  blockId: string,
   className: string,
   rootClassName: string,
   textClassName: string,

diff --git a/src/containers/PageBuilder/BlockBuilder/BlockSocialMediaLink/BlockSocialMediaLink.js b/src/containers/PageBuilder/BlockBuilder/BlockSocialMediaLink/BlockSocialMediaLink.js
@@ -36,7 +36,7 @@ BlockSocialMediaLink.defaultProps = {
 };
 
 BlockSocialMediaLink.propTypes = {
-  blockId: string.isRequired,
+  blockId: string,
   className: string,
   rootClassName: string,
   link: propTypeLink,