Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 찜 목록 페이지 infinite query로 마이그레이션 #351

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

kyuhho
Copy link
Contributor

@kyuhho kyuhho commented Jul 14, 2024

Checklist


  • 올바른 브랜치에 PR을 보내도록 설정하였나요?
  • PR의 라벨을 올바르게 달았나요?

Description


찜 목록 페이지 infinite query로 변경

기존의 목적은 찜을 취소하면 visiblity를 false로 만드는 방식으로 즉각적으로 반영되는 것처럼 구현하였으나, 엠티 뷰가 안보이는 이슈가 있어 infinite query로 마이그레이션하여 해결하려하였습니다.

하지만 query를 invalidate할 때마다 깜빡임 이슈가 있었고, 다른 래퍼런스 페이지 찾아본 결과 좋아요 혹은 스크랩을 취소해도 바로 없어지지 않게 구현이 돼있어, infinite query로만 변경하게 되었습니다.


Related Issues


#350

@kyuhho kyuhho added Refactor 코드 리팩토링 Stage-2/code-review-request work done and CI passed Chore 자잘한 수정 labels Jul 14, 2024
@kyuhho kyuhho self-assigned this Jul 14, 2024
Copy link

netlify bot commented Jul 14, 2024

Deploy Preview for candid-semolina-d0db42 ready!

Name Link
🔨 Latest commit c9a88c5
🔍 Latest deploy log https://app.netlify.com/sites/candid-semolina-d0db42/deploys/6693ad19fa474c0008b3fd71
😎 Deploy Preview https://deploy-preview-351--candid-semolina-d0db42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmdnps10
Copy link
Contributor

빠른 시간 내에 곧 리뷰하겠습니다!!

@rmdnps10
Copy link
Contributor

더 좋은 사용자 경험인 거 같습니다 🫡🫡

@rmdnps10 rmdnps10 merged commit 13345cd into dev Jul 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore 자잘한 수정 Refactor 코드 리팩토링 Stage-2/code-review-request work done and CI passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants