Feat/minder profile layout 329 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for candid-semolina-d0db42 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmdnps10
reviewed
Jul 1, 2024
| if (id !== undefined) { | ||
| const counselorId = parseInt(id, 10); | ||
| return ( | ||
| <Wrapper className="header"> |
There was a problem hiding this comment.
Wrapper의 className을 header로 지정해주신 이유가 있나요???
There was a problem hiding this comment.
전에 썼던 클래스네임을 지우면서 추가되어있는 것 같습니다! 삭제하였습니다 ㅎㅎ a27558b
| <Subtitle color={Grey1} style={{ textAlign: 'left', width: '100%' }}> | ||
| 이런 분야에 자신 있어요 | ||
| </Subtitle> | ||
| <Flex gap="0.8rem" justify="flex-start"> |
There was a problem hiding this comment.
Flex 컴포넌트를 이렇게 삽입하는 게 개발할 때는 편한데 의미론적으로 (코드 가독성 부문에서) 조금 아쉽긴 한 거 같다는 생각도 한편으로는 드는 거 같습니다.
Flex 컴포넌트 상속으로 컴포넌트명을 적당히 재선언해주면 나아지려나요.
근데 이렇게할바에 스타일드컴포넌트 방식으로 템플릿 리터럴방식으로 flex를 설정할 것 같기도하고... 애매하네요 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
마인더 프로필 레이아웃 변경사항 반영하였습니다.
Related Issues
#329
To Reveiwer
Figma