[Feature] 리뉴얼된 디자인 반영 및 각종 아이콘/그래픽 통일성 부여 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmdnps10
added
Bug
✅ Deploy Preview for candid-semolina-d0db42 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kyuhho
reviewed
Jun 23, 2024
Comment on lines
+92
to
+101
| width: 100%; | ||
| span#current-time { | ||
| color: ${Green}; | ||
| } | ||
| .row1 { | ||
| display: flex; | ||
| width: 100%; | ||
| align-items: center; | ||
| } | ||
| `; |
There was a problem hiding this comment.
💡(suggestion) flex 컴포넌트가 추가되어 추후에 활용하면 좋을 것 같아요!
| @@ -42,7 +43,7 @@ function SellerRefundBankAccount() { | |||
| fetchAccountData(); | |||
| }, []); | |||
| useEffect(() => { | |||
| if (accountNum !== '' && bankType !== '' && owner !== '') { | |||
There was a problem hiding this comment.
💡(suggestion) 이렇게 세가지가 역인 state의 경우, 꼭 isActiveFinishButton state를 따로 선언하여 useEffect로 관리하지 않아도,
const [accountNum, setAccountNum] = useState<string>('');
const [bankType, setBankType] = useState<string>('');
const [owner, setOwner] = useState<string>('');
const isActiveFinishButton = accountNum?.length > 0 && bankType?.length > 0 && owner?.length > 0;
위와 같이 구현하면 state로 인한 DOM 리렌더를 줄일 수 있을 것 같습니다~!
There was a problem hiding this comment.
감사합니다! 이 방식이 더 효율적일 거 같아서 반영하였습니다:)
Comment on lines
+109
to
+130
| { | ||
| isLoading ? ( | ||
| <div | ||
| style={{ | ||
| height: 'calc(70vh)', | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| }} | ||
| > | ||
| <LoadingSpinner /> | ||
| </div> | ||
| ) : // 상담카드 부분 | ||
| openConsultList.length === 0 ? ( | ||
| <EmptyWrapper> | ||
| <EmptyIcon /> | ||
| <Heading>아직 진행한 상담이 없어요</Heading> | ||
| <Space height="1rem" /> | ||
| <Body2>상담은 공개상담 탭에서 신청할 수 있어요.</Body2> | ||
| </EmptyWrapper> | ||
| ) : ( | ||
| <BuyerOpenConsultCardList> | ||
| {openConsultList?.map((item) => { |
There was a problem hiding this comment.
💡(suggestion) 이렇게 nested 삼항연산자를 사용해야하는 구조의 경우에는 아래와 같이 작성하여 가독성을 높일 수 있을 것 같습니다!
const renderConsultCard = ()=>{
if(isLoading){
return ...
}
if(openConsultList.length === 0){
return ...
}
return ...
}
//
//
//
return {
<>
{renderConsultCard()}
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
남은 리뉴얼된 디자인들을 반영하면서, 자잘한 Hotfix 해결, 아이콘/디자인 통일 등을 구현했습니다.
Related Issues
#307
To Reveiwer
피그마에서 아직 <작업 중> 딱지가 붙은 페이지는 작업하지 않았습니다! 그 외 나머지 새로 나온 디자인들은 모두 반영하려고 했는데, 반영안된거나 문제가 있으면 말씀해주세요.