-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] 검색 페이지, 찜 목록 페이지 리뉴얼된 버전으로 업데이트 + 검색 필터링 쿼리파라미터로 추가하여 검색 결과 유지 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for candid-semolina-d0db42 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmdnps10
changed the title
[Feature] 검색 페이지, 찜 목록 페이지 리뉴얼된 버전으로 업데이트
[Feature] 검색 페이지, 찜 목록 페이지 리뉴얼된 버전으로 업데이트 + 검색 펄터링 쿼리파라미터로 추가하여 검색 결과 유지
Apr 19, 2024
rmdnps10
changed the title
[Feature] 검색 페이지, 찜 목록 페이지 리뉴얼된 버전으로 업데이트 + 검색 펄터링 쿼리파라미터로 추가하여 검색 결과 유지
[Feature] 검색 페이지, 찜 목록 페이지 리뉴얼된 버전으로 업데이트 + 검색 필터링 쿼리파라미터로 추가하여 검색 결과 유지
Apr 19, 2024
kyuhho
reviewed
Apr 19, 2024
src/components/Buyer/BuyerSavedCounselor.tsx/SavedCounselorCard.tsx
Outdated
Show resolved
Hide resolved
src/components/Buyer/BuyerSavedCounselor.tsx/SavedCounselorCard.tsx
Outdated
Show resolved
Hide resolved
src/components/Buyer/BuyerSavedCounselor.tsx/SavedOpenConsultResults.tsx
Show resolved
Hide resolved
Comment on lines
+20
to
+42
{tabState === 1 ? ( | ||
<> | ||
<Subtitle color={Green}>상담사</Subtitle> | ||
<UnderLineBuyer /> | ||
</> | ||
) : ( | ||
<Subtitle color={Grey4}>상담사</Subtitle> | ||
)} | ||
</TabButton> | ||
<TabButton | ||
tabState={2} | ||
onClick={() => { | ||
setTabState(2); | ||
}} | ||
> | ||
{tabState === 2 ? ( | ||
<> | ||
<Subtitle color={Green}>공개상담</Subtitle> | ||
<UnderLineBuyerBig /> | ||
</> | ||
) : ( | ||
<Subtitle color={Grey4}>공개상담</Subtitle> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
공통 컴포넌트이기 때문에 Divider2
로 사용하게 된다면, subtitle의 text도 props로 받는게 좋을거 같습니다!
고생하셨습니다~~~~~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
위 부분을 고정시켜놓았어요~
20240429 - 검색 필터링 조건 및 검색어를 쿼리스트링 값으로 추가했습니다.
Related Issues
#228
To Reveiwer
`useSearchPageParams` 커스터 훅을 통하여 쿼리스트링 값을 반영하였습니다~!