Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for running tests #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ericyhwang
Copy link
Contributor

The tests in this repo are integration tests that don't work without a Mongo already running, but there aren't currently any instructions, which can be confusing for first-time contributors.

Having the instructions also helps more frequent contributors like us too. It always takes me a few minutes to figure out the exact Docker invocation to start the container.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.458% when pulling abc7a25 on test-instructions into ea464d9 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.458% when pulling abc7a25 on test-instructions into ea464d9 on master.

@alecgibson
Copy link
Contributor

This looks fine to me, although my immediate thoughts are:

  • not everyone has Docker installed (and it's a pretty heavy install)
  • perhaps we should move to using something like mongodb-memory-server? We're using it on one of our projects, and it seems to work pretty well. It's nice because it'll "just work" regardless of development setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants