Skip to content

Commit

Permalink
Merge branch 'main' into fmt_compact_fd
Browse files Browse the repository at this point in the history
  • Loading branch information
sffc committed Sep 20, 2023
2 parents b431bf5 + a5c61d6 commit b352c49
Show file tree
Hide file tree
Showing 704 changed files with 31,666 additions and 19,851 deletions.
1 change: 1 addition & 0 deletions .github/workflows/artifacts-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ jobs:
- components/locid_transform
- components/plurals
- components/segmenter
- experimental/transliterate
- experimental/zerotrie
- utils/fixed_decimal
- utils/litemap
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ concurrency:
jobs:

# ci-job-check & ci-job-features
# Running at MSRV (1.65)
# Running at MSRV (1.66)
msrv:
runs-on: ubuntu-latest
# Defined as a matrix so that features can start immediately, but
Expand All @@ -41,6 +41,10 @@ jobs:
matrix:
behavior: [check, features-1, features-2, features-3]
fail-fast: true
# Set CARGO_HTTP_MULTIPLEXING=false to work around crates.io curl bug:
# <https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/timeout.20investigation>
env:
CARGO_HTTP_MULTIPLEXING: false
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -235,6 +239,9 @@ jobs:
path: /tmp/icu4x-source-cache

# Actual job
- name: Run `cargo make testdata-check`
run: cargo make testdata-check

- name: Run `cargo make testdata-legacy`
run: cargo make testdata-legacy

Expand Down Expand Up @@ -580,7 +587,6 @@ jobs:
# ci-job-fmt
fmt:
if: github.event_name != 'schedule'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ Note: A subset of crates received patch releases in the 1.2 stream.
- Support configurable grouping separators in CompactDecimalFormatter (#3045)
- `icu_displaynames`: 0.8.0 -> 0.10.0
- Add ScriptDisplayNames (#3317)
- Add LangaugeDisplayNames with support for variants (#3058, #3113)
- Add LanguageDisplayNames with support for variants (#3058, #3113)
- Add stronger typing (#3190)
- `icu_harfbuzz`: New experimental port: Harfbuzz integration for ICU4X (v0.1.0)
- `icu_relativetime`: 0.1.0 -> 0.1.1
Expand Down Expand Up @@ -221,7 +221,7 @@ Note: A subset of crates received patch releases in the 1.2 stream.
* icu_segmenter: enforce `clippy::indexing_slicing`. (#2325)
* Use `GraphemeClusterSegmenter` in `DictionarySegmenter` and `LstmSegmenter` (#2716)
* Rename `*BreakSegmenter` to `*Segmenter` (#2707)
* Remove unnecessary langauge check for East Asian languagne (SA property) (#2705)
* Remove unnecessary language check for East Asian language (SA property) (#2705)
* internal and doc improvements

* `icu_timezone`
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ The other is the review cycle.
#### Draft Phase

If the pull request is simple and short lived, it can be initialized with review request.
If the pull request is more complex and is being developed over time, it may be benefitial to start it in a `Draft` state.
If the pull request is more complex and is being developed over time, it may be beneficial to start it in a `Draft` state.
This allows other contributors to monitor the progress and volunteer feedback while annotating that the pull request is not yet ready for review.

If a pull request is particularly large in scope and not release-ready, consider either (1) reducing the scope of the pull request, (2) moving work to the `experimental/` directory, or (3) hiding the work behind the `"experimental"` feature flag. See the section above, "Release Readiness", for more details.
Expand Down Expand Up @@ -175,10 +175,10 @@ In such cases, *mentorship model* should be used where a more senior engineer ta
When the PR author creates a new PR, they should consider three sources of reviewers and informed stakeholders:

* Owners and peers of the component they work with
* People involved in the preceeding conversation
* People involved in the preceding conversation
* Recognized experts in the domain the PR operates in

The goal of the PR author is to find the subset of stakeholders that represent those three groups well. Depending on the scope and priority of the PR, the reviewers group size can be adjusted, with small PRs being sufficent for review by just one stakeholder, and larger PRs, or first-of-a-kind using a larger pool of reviewers.
The goal of the PR author is to find the subset of stakeholders that represent those three groups well. Depending on the scope and priority of the PR, the reviewers group size can be adjusted, with small PRs being sufficient for review by just one stakeholder, and larger PRs, or first-of-a-kind using a larger pool of reviewers.

### PR author and reviewers workflow

Expand Down
Loading

0 comments on commit b352c49

Please sign in to comment.