Bump less-rails to remove deprecation warnings, fixes #925 #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning is: ``` DEPRECATION WARNING: Sprockets method `register_engine` is deprecated. Please register a mime type using `register_mime_type` then use `register_compressor` or `register_transformer`. ``` This problem is really a less-rails error, and is documented in this issue of that repo: metaskills/less-rails#122 It was fixed with this PR, merged Oct 2017: metaskills/less-rails#137 Bumping our less-rails dependency to 3.0.0 will give us the updates in that PR. Version 3.0.0 is the next version after 2.8.0, so there are very few other changes to worry about. You can view all of the less-rails code changes between 2.8.0 and 3.0.0 here: metaskills/less-rails@05186eb...7bb14e5 They are almost all test and/or README changes. So this update should be low risk.
|
When are you going to merge this PR? It could solve the unwanted warnings issue. |
|
Any chance this could get merged and a new release cut? I'd love to see these deprecation warnings get fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning is:
This problem is really a less-rails error, and is documented in this
issue of that repo:
metaskills/less-rails#122
It was fixed with this PR, merged Oct 2017:
metaskills/less-rails#137
Bumping our less-rails dependency to 3.0.0 will give us the updates in
that PR.
Version 3.0.0 is the next version after 2.8.0, so there are very few
other changes to worry about. You can view all of the less-rails code
changes between 2.8.0 and 3.0.0 here:
metaskills/less-rails@05186eb...7bb14e5
They are almost all test and/or README changes. So this update should be
low risk.