Provide support for custom tsconfig files in serverless.ts definitions #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2021 13:45
Signed-off-by: Nick Hammond <[email protected]>
Signed-off-by: Nick Hammond <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #8931 +/- ##
==========================================
- Coverage 87.68% 87.56% -0.12%
==========================================
Files 268 268
Lines 10041 10066 +25
==========================================
+ Hits 8804 8814 +10
- Misses 1237 1252 +15
Continue to review full report at Codecov.
|
|
@nhammond101 great thanks for the effort. Still as discussed at serverless/typescript#28 ideally if we can keep any TS related handling externally and not in context of this repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to allow the specifying of different tsconfig*.json files (tsconfig.app.json, tsconfig.serverless.json, etc) via the command line and the loading of tsconfig-paths if it's found within the project.
Primary use case is to support tsconfig paths, allowing the typescript compiler to use different paths when compiling the serverless.ts definition file.
Monorepos such as nx rely heavily on multiple modules referenced via the paths but currently serverless.ts won't be able to utilise it without tsconfig-paths
Addresses #8932