-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customization options for Serverless action #90
Open
ryanlawson
wants to merge
9
commits into
serverless:next
Choose a base branch
from
ryanlawson:master
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanlawson
changed the title
Allow a particular Serverless version to be set
Allow a particular Serverless version or working directory
May 18, 2024
ryanlawson
force-pushed
the
master
branch
6 times, most recently
from
May 18, 2024 05:23
9e4d135
to
36f0d79
Compare
ryanlawson
force-pushed
the
master
branch
6 times, most recently
from
May 18, 2024 08:37
38d0cf3
to
32bfd50
Compare
This was referenced May 18, 2024
ryanlawson
changed the title
Allow a particular Serverless version or working directory
Add customization options for Serverless action
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21
Resolves #33
Resolves #69
Resolves #77
Resolves #84
Allows a user to specify a
serverless-version
or defaults tolatest
.Allows a user to specify a
working-directory
or defaults to.
.Throws an error if no
args
are passed (with an error message).Includes an
aws-credentials
flag underwith:
to automatically add--use-local-credentials
to the end ofargs
.Allows a user to pass a list of plugins in
install-packagages
to be installed before runningargs
.Updates
action.yml
andREADME.md
.Note: Because it calls
/entrypoint.sh
instead ofserverless
directly, specifying the/bin/sh
entrypoint will include arguments passed to/entrypoint.sh
. Hence I recommend bumping to v4 as this could be considered a breaking change.Testing: https://github.com/ryanlawson/actions-test/actions/runs/9142765035/job/25138829111