-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Export 'project-name-ServerlessAliasReference' does not exist. #186
base: master
Are you sure you want to change the base?
Conversation
Enase
commented
Mar 25, 2020
•
edited
Loading
edited
- Fixes ServerlessError: Export 'project-name-ServerlessAliasReference' does not exist. #181
- adds support for serverless v2
- drops support for serverless v1
- updated dependencies
@HyperBrain could you merge / release? |
What's the ETA for the fix to be merged? |
Sorry |
can we get this released this week? This seems to be a fix much needed for people to use it with latest serverless versions |
@HyperBrain Can you kindly review the PR please? It'll be great to use this plugin with the latest framework core version. Much appreciated! |
I get the error.. Serverless Error --------------------------------------- Export 'project-name-ServerlessAliasReference' does not exist. Get Support -------------------------------------------- Your Environment Information --------------------------- |
How are people creating a new project with this plugin without this patch??? |
I don't think anyone is creating new projects with the latest serverless version. Most likely they are locking down the serverless version |
Any news on this issue ? I'm also hitting this problem |
I am evaluating this plugin for a client and am in a situation where they can't use serverless <=1.62. Merging this fix would be very appreciated. |
lib/stackInformation.js
Outdated
@@ -82,7 +82,9 @@ module.exports = { | |||
.mapSeries(stack => BbPromise.join(BbPromise.resolve(stack), this.aliasStackLoadTemplate(stack))) | |||
.map(stackInfo => ({ stack: stackInfo[0], template: stackInfo[1] })) | |||
.catch(err => { | |||
if (err.statusCode === 400) { | |||
if (err.statusCode === 400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about (to make it easier to understand):
if (err.statusCode === 400 | |
if ( | |
err.statusCode === 400 || | |
( | |
err.statusCode === undefined && | |
err.providerError && | |
err.providerError.statusCode === 400 | |
) | |
) { |
package.json
Outdated
"sinon-chai": "^3.3.0" | ||
"mocha": "^7.1.1", | ||
"nyc": "^15.0.0", | ||
"serverless": "^1.67.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an older version of Serverless, should it be updated?
Hey, does anyone can approve this merge ? |
Any chances of this PR to be approved? |
@HyperBrain, could you please review/merge this one? Since it's really a bottleneck for projects of mine, we don't want to give up on using this plugin) |
@HyperBrain Any updates?... |
@Enase Would you consider releasing it as a separate package ( |
@Bielik20 Feel free to use serverless-aws-alias-fixed Hope it helps everyone.. |
If this has been fixed, please merge. Would really appreciate it. |
I have issue with serverless-aws-alias-fixed TypeError: Cannot read property 'Properties' of undefined |
@ABRIO-PR Hello! |
@Enase I set "role" at the provider and it working. But if set role at functions: TypeError: Cannot read property 'Properties' of undefined |
@ABRIO-PR I'm not sure will it work or not, but you can try to apply this patch and let us know the result. fix.patch
|
This is an inspiration from the fix that @Enase provided long back and not merged. Tested in my local setup and works. Fixes issue serverless-heaven#186 and serverless-heaven#200
This is an inspiration from the fix that @Enase provided long back and not merged. Tested in my local setup and works. Fixes issue serverless-heaven#186 and serverless-heaven#200
Created a separate PR for this with only needed change #201 |
@HyperBrain could this be merged? HyperBrain seems inactive in git over the last 2 years... Should we fork this plugin to a new repo? |
Can someone review and merge this please? |