Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v4 #361

Merged
merged 91 commits into from
Jul 18, 2024
Merged

feat: v4 #361

merged 91 commits into from
Jul 18, 2024

Conversation

jacoobes
Copy link
Member

No description provided.

jacoobes and others added 30 commits April 28, 2024 13:48
@jacoobes
step 1
30230d4
@jacoobes
Refactorings
6228f53
@jacoobes
command modules do not depend on anything but itself
599a02c
@jacoobes
tearing it up
3d10ee1
@jacoobes
Remove module store, manager, and Intializable type
76ee9c6
@jacoobes
consolidate interfaces in single file
f5136ba
@jacoobes
consolidate default services in single file
9faae7e
@jacoobes
TEAR IT UP
6105f7b
@jacoobes
fix text compile
68c5f09
@jacoobes
the end of sern init??
071d5ea
@jacoobes
Presence namespaced types removed
e6fba9d
@jacoobes
internal namespace
821de65
@jacoobes
clean up dependencies
87c5631
@jacoobes
fix test
6c61ae7
@jacoobes
fix circular dependency
52d1b5a
@jacoobes
still broken but progress
5b33a9d
@jacoobes
remove barrel for core/structs
d6eedb1
@jacoobes
reffactor
e8cfcc2
@jacoobes
refactor allat
0488f45
@jacoobes
more refactoring
219eda9
@jacoobes
prototyping linking static handler
d3245c8
@jacoobes
cleanup tests, codegen, and importing handler
d7ebdb2
@jacoobes
some refactor
545105e
@jacoobes
generify partition
b0e9d15
@jacoobes
for now copy paste new ioc system
cd92b54
@jacoobes
removeiti
f762033
@jacoobes
fdsfD
08ef805
@jacoobes
ensure container is init'd
ffb2872
@jacoobes
fix absPath gen
4d74e63
@jacoobes
working on bun compat
8554eea
@jacoobes jacoobes requested a review from EvolutionX-10 June 24, 2024 03:10
@SrIzan10
Copy link
Member

@jacoobes open pr?

@jacoobes jacoobes requested a review from SrIzan10 June 24, 2024 13:35
@jacoobes jacoobes marked this pull request as ready for review June 24, 2024 13:35
SrIzan10
SrIzan10 reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@SrIzan10 SrIzan10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, very awesome, i think we can fire the magic @sernbot command
edit: forgot to mark as good

src/core/presences.ts Outdated Show resolved Hide resolved
src/handlers/ready.ts Show resolved Hide resolved
@SrIzan10 SrIzan10 self-requested a review June 24, 2024 22:15
@SrIzan10
Copy link
Member

it looks like @discordjs/ws has a vulnerable version of the ws package, so this can be merged safely and we'll update the package when it's fixed upstream

@SrIzan10
Copy link
Member

@sernbot ready to merge

@sernbot
Copy link
Member

sernbot commented Jun 25, 2024

Hey @SrIzan10! I only need one more approval by the dev team before I can merge this PR.
Just run the command approve merge.

@SrIzan10
Copy link
Member

image
this is gonna be a reality in a few days if not today

@EvolutionX-10
Copy link
Member

That is a beefy PR god damn

EvolutionX-10
EvolutionX-10 requested changes Jun 26, 2024
View reviewed changes
src/core/functions.ts Outdated Show resolved Hide resolved
src/core/id.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@EvolutionX-10
Copy link
Member

Some files are pending to be seen, i'll see them soon:tm:

@jacoobes jacoobes merged commit 9a8904f into main Jul 18, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvolutionX-10 EvolutionX-10 EvolutionX-10 requested changes

@SrIzan10 SrIzan10 SrIzan10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacoobes @SrIzan10 @sernbot @EvolutionX-10