Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: queuing events (#332) @Benzo-Fury #333

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: queuing events (#332) @Benzo-Fury #333

merged 2 commits into from
Nov 6, 2023

Conversation

Benzo-Fury
Copy link
Contributor

No description provided.

@Benzo-Fury Benzo-Fury requested a review from jacoobes as a code owner October 6, 2023 01:56
@Benzo-Fury Benzo-Fury changed the title fix: queuing events fix: queuing events #332 Oct 6, 2023
@Benzo-Fury Benzo-Fury changed the title fix: queuing events #332 fix: queuing events (#332) Oct 6, 2023
@Benzo-Fury
Copy link
Contributor Author

Ignore all the name changes 🙈

@Benzo-Fury
Copy link
Contributor Author

Most recent commit removes the fix, possibly revert back to the first commit.

SrIzan10
SrIzan10 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@SrIzan10 SrIzan10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi

@jacoobes jacoobes mentioned this pull request Oct 7, 2023
Closed
@jacoobes jacoobes linked an issue Oct 9, 2023 that may be closed by this pull request
[BUG] sern Queueing/Awaiting commands #332
Closed
@jacoobes
Copy link
Member

jacoobes commented Oct 13, 2023 •
edited
Loading

Redirect: this will be merged into another subbranch

@jacoobes jacoobes changed the base branch from main to feat/errors October 13, 2023 21:07
@jacoobes jacoobes changed the base branch from feat/errors to main November 2, 2023 19:08
@jacoobes jacoobes changed the title fix: queuing events (#332) fix: queuing events (#332) @Benzo-Firy Nov 6, 2023
@jacoobes jacoobes changed the title fix: queuing events (#332) @Benzo-Firy fix: queuing events (#332) @Benzo-Fury Nov 6, 2023
jacoobes
jacoobes approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@jacoobes jacoobes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, no more blocking commands

@jacoobes jacoobes merged commit fd39858 into sern-handler:main Nov 6, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoobes jacoobes jacoobes approved these changes

@SrIzan10 SrIzan10 SrIzan10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] sern Queueing/Awaiting commands
3 participants
@Benzo-Fury @jacoobes @SrIzan10