Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

fix(pixabay): Shrink pixabay source button #344

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

CodingDive
Copy link
Contributor

@CodingDive CodingDive commented Feb 27, 2024

Worked great! Thanks for the demo Lars! ❤️

Before

Screenshot from 2024-02-27 15-33-26

After

Screenshot from 2024-02-27 15-33-01

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
serlo-editor-for-edusharing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 3:21pm

@CodingDive CodingDive merged commit 5ad07f1 into main Feb 27, 2024
10 checks passed
@CodingDive CodingDive deleted the fix/shrink-pixabay-src-button branch February 27, 2024 15:44
Copy link
Member

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! :)

@@ -97,13 +104,43 @@ export function EdusharingAssetRenderer(props: {
'edusharing_rendering_content_footer { display: none;',
)

if (
content?.mimeType === 'image/jpeg' &&
content?.node?.remote?.repository?.repositoryType === 'PIXABAY'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know that we could get the type info from this. Nice find!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants