Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(backend): transpile and bundle using esbuild #68

Merged

Conversation

hejtful
Copy link
Collaborator

@hejtful hejtful commented Sep 27, 2024

Part of: https://linear.app/serlo/issue/PE-128/deployment-of-found-solution-for-serlo-editor-as-lti-tool

Changes:

  • When transpiling to CommonJS, import.meta.dirname is unnecessary
  • Single script for building frontend and backend, both have their respective directories in dist

Manual tests:

  • Still works in local with docker
  • Still works in Uberspace

Copy link
Member

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you!
I only feel like we could merge the two Dockerfiles into one. But we can do that later.

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel merged commit 5c6ff65 into development Sep 30, 2024
4 checks passed
@LarsTheGlidingSquirrel LarsTheGlidingSquirrel deleted the build/transpile-bundle-backend-esbuild branch September 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants