Refactoring and Performance Optimizations #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ckadluba
commented
Nov 14, 2024
ckadluba
commented
- Refactoring and performance optimizations in batched and audit sink
- Create perftest result on release
- Updated issue template
- Updated editorconfig
- Added specific documentation about when SQL SELECT permission is not required
SELECT permissions are not required in all cases.
Upload performance test results as an artifact in release.yml
Refactoring * Removed DataTableCreator from class MsSqlServerSink. Pushed it down to SqlBulkBatchWriter. This also made it possible to remove reference to System.Data in MsSqlServerSink. * Removed DataTableCreator from SinkDependencies. * Removed IBulkBatchWriter interface from SqlInsertStatementWriter. MSSqlServerSink class now has separate instances of ISqlBulkBatchWriter and ISqlLogEventWriter and chooses which one to use based on sink option `UseSqlBulkCopy`. * Added new class SqlCommandFactory with interface ISqlCommandFactory Performance optimizations in batched sink * Generate schema and table string only once and do not use string.Format(). * Do not cast on each column of each log event. Performance optimizations in audit sink * Render INSERT string only once and not for each log event since it will not change between log events. * Do not create a separate SqlCommand for each log event. Reuse the same and set only new SqlConnection, CommandText and parameters for each log event. Added new tests and adapted existing ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.