Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a string truncate bug #506

Merged

Conversation

Whinarn
Copy link
Contributor

@Whinarn Whinarn commented Dec 21, 2023

Added a fix for a bug introduced in v6.4.0 where NVarChar columns with a data length of 1 would always end up as an empty string inside the database.

Fixes #505

@ckadluba ckadluba added this pull request to the merge queue Jan 10, 2024
Merged via the queue into serilog-mssql:dev with commit 287b9d3 Jan 10, 2024
5 checks passed
@ckadluba
Copy link
Member

Thank you for the contribution. It is very welcome! :)

@Whinarn Whinarn deleted the bug/505-dont-truncate-short-strings branch January 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVarChar Columns with 1 data length gets their values truncated into empty strings
3 participants