Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robustness to failure of python multiprocessing #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add robustness to failure of python multiprocessing #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dd8f6c
add robustness to multiprocessing failure, this might happen for proc…
petercorke Dec 8, 2024
c7edb1b
fix cut and paste error
petercorke Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions amazon_paapi/sdk/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,12 @@ def __init__(self,
configuration = Configuration()
self.configuration = configuration

self.pool = ThreadPool()
try:
self.pool = ThreadPool()
except:
# if multiprocessing is not available, we can't use the pool
self.pool = None

self.rest_client = rest.RESTClientObject(configuration)
self.default_headers = {}
if header_name is not None:
Expand All @@ -103,8 +108,9 @@ def __init__(self,
self.region = region

def __del__(self):
self.pool.close()
self.pool.join()
if self.pool is not None:
self.pool.close()
self.pool.join()

@property
def user_agent(self):
Expand Down