Skip to content

Commit

Permalink
[MRG + 1] DOC Add whatsnew for the 3 model_selection bugfixes (scikit…
Browse files Browse the repository at this point in the history
…-learn#7868)

* DOC Add whatnew for the 3 mod-sel bugfixes

* Move to 0.18.1; Change name universally to Raghav RV

* Raghav R V --> Raghav RV

* Edit mailmap to include my other email
  • Loading branch information
raghavrv authored Nov 15, 2016
1 parent 38ca830 commit 680a5b8
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 15 deletions.
3 changes: 2 additions & 1 deletion .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ Olivier Grisel <[email protected]> <[email protected]>
Olivier Hervieu <[email protected]> <[email protected]>
Paul Butler <[email protected]>
Peter Prettenhofer <[email protected]>
Raghav R V <[email protected]>
Raghav RV <[email protected]>
Raghav RV <[email protected]> <[email protected]>
Robert Layton <[email protected]>
Roman Sinayev <[email protected]>
Roman Sinayev <[email protected]> <roman@y570.(none)>
Expand Down
4 changes: 2 additions & 2 deletions doc/about.rst
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Environment also funds several students to work on the project part-time.
:target: http://cds.nyu.edu/mooresloan/

`Télécom Paristech <http://www.telecom-paristech.com>`_ funds Manoj Kumar (2014),
Tom Dupré la Tour (2015), Raghav R V (2015-2016) and Thierry Guillemot (2016) to
Tom Dupré la Tour (2015), Raghav RV (2015-2016) and Thierry Guillemot (2016) to
work on scikit-learn.

.. image:: themes/scikit-learn/static/img/telecom.png
Expand All @@ -114,7 +114,7 @@ program.
- 2012 - `Vlad Niculae`_, Immanuel Bayer.
- 2013 - Kemal Eren, Nicolas Trésegnie
- 2014 - Hamzeh Alsalhi, Issam Laradji, Maheshakya Wijewardena, Manoj Kumar.
- 2015 - `Raghav R V <https://github.com/raghavrv>`_, Wei Xue
- 2015 - `Raghav RV <https://github.com/raghavrv>`_, Wei Xue
- 2016 - `Nelson Liu <http://nelsonliu.me>`_, `YenChen Lin <http://yclin.me>`_

It also provided funding for sprints and events around scikit-learn. If
Expand Down
38 changes: 27 additions & 11 deletions doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,22 @@ Bug fixes
has less number of classes than the total data. :issue:`7799` by
`Srivatsan Ramesh`_

- Fixed a bug where :func:`sklearn.model_selection.train_test_split` raised
an error when ``stratify`` is a list of string labels. :issue:`7593` by
`Raghav RV`_.

- Fixed a bug where :class:`sklearn.model_selection.GridSearchCV` and
:class:`sklearn.model_selection.RandomizedSearchCV` were not pickleable
because of a pickling bug in ``np.ma.MaskedArray``. :issue:`7594` by
`Raghav RV`_.

- All cross-validation utilities in :mod:`sklearn.model_selection` now
permit one time cross-validation splitters for the ``cv`` parameter. Also
non-deterministic cross-validation splitters (where multiple calls to
``split`` produce dissimilar splits) can be used as ``cv`` parameter.
The :class:`sklearn.model_selection.GridSearchCV` will cross-validate each
parameter setting on the split produced by the first ``split`` call
to the cross-validation splitter. :issue:`7660` by `Raghav RV`_.

API changes summary
-------------------
Expand Down Expand Up @@ -357,7 +373,7 @@ Model selection and evaluation
- The cross-validation iterators are replaced by cross-validation splitters
available from :mod:`sklearn.model_selection`, allowing for nested
cross-validation. See :ref:`model_selection_changes` for more information.
:issue:`4294` by `Raghav R V`_.
:issue:`4294` by `Raghav RV`_.

Enhancements
............
Expand Down Expand Up @@ -474,7 +490,7 @@ Model evaluation and meta-estimators
- The new ``cv_results_`` attribute of :class:`model_selection.GridSearchCV`
(and :class:`model_selection.RandomizedSearchCV`) can be easily imported
into pandas as a ``DataFrame``. Ref :ref:`model_selection_changes` for
more information. :issue:`6697` by `Raghav R V`_.
more information. :issue:`6697` by `Raghav RV`_.

- Generalization of :func:`model_selection.cross_val_predict`.
One can pass method names such as `predict_proba` to be used in the cross
Expand All @@ -484,7 +500,7 @@ Model evaluation and meta-estimators
- The training scores and time taken for training followed by scoring for
each search candidate are now available at the ``cv_results_`` dict.
See :ref:`model_selection_changes` for more information.
:issue:`7325` by :user:`Eugene Chen <eyc88>` and `Raghav R V`_.
:issue:`7325` by :user:`Eugene Chen <eyc88>` and `Raghav RV`_.

Metrics

Expand All @@ -499,7 +515,7 @@ Metrics
:issue:`7419` by :user:`Gregory Stupp <stuppie>` and `Joel Nothman`_.

- Add ``sample_weight`` parameter to :func:`metrics.matthews_corrcoef`.
By :user:`Jatin Shah <jatinshah>` and `Raghav R V`_.
By :user:`Jatin Shah <jatinshah>` and `Raghav RV`_.

- Speed up :func:`metrics.silhouette_score` by using vectorized operations.
By `Manoj Kumar`_.
Expand Down Expand Up @@ -730,13 +746,13 @@ Model evaluation and meta-estimators
:mod:`sklearn.learning_curve` have been deprecated and the classes and
functions have been reorganized into the :mod:`sklearn.model_selection`
module. Ref :ref:`model_selection_changes` for more information.
:issue:`4294` by `Raghav R V`_.
:issue:`4294` by `Raghav RV`_.

- The ``grid_scores_`` attribute of :class:`model_selection.GridSearchCV`
and :class:`model_selection.RandomizedSearchCV` is deprecated in favor of
the attribute ``cv_results_``.
Ref :ref:`model_selection_changes` for more information.
:issue:`6697` by `Raghav R V`_.
:issue:`6697` by `Raghav RV`_.

- The parameters ``n_iter`` or ``n_folds`` in old CV splitters are replaced
by the new parameter ``n_splits`` since it can provide a consistent
Expand All @@ -757,7 +773,7 @@ Model evaluation and meta-estimators
:class:`model_selection.LeavePGroupsOut` is renamed to
``groups``. Additionally in :class:`model_selection.LeavePGroupsOut`,
the parameter ``n_labels`` is renamed to ``n_groups``.
:issue:`6660` by `Raghav R V`_.
:issue:`6660` by `Raghav RV`_.

Code Contributors
-----------------
Expand Down Expand Up @@ -1314,7 +1330,7 @@ Mathieu Blondel, Matt Krump, Matti Lyra, Maxim Kolganov, mbillinger, mhg,
Michael Heilman, Michael Patterson, Miroslav Batchkarov, Nelle Varoquaux,
Nicolas, Nikolay Mayorov, Olivier Grisel, Omer Katz, Óscar Nájera, Pauli
Virtanen, Peter Fischer, Peter Prettenhofer, Phil Roth, pianomania, Preston
Parry, Raghav R V, Rob Zinkov, Robert Layton, Rohan Ramanath, Saket Choudhary,
Parry, Raghav RV, Rob Zinkov, Robert Layton, Rohan Ramanath, Saket Choudhary,
Sam Zhang, santi, saurabh.bansod, scls19fr, Sebastian Raschka, Sebastian
Saeger, Shivan Sornarajah, SimonPL, sinhrks, Skipper Seabold, Sonny Hu, sseg,
Stephen Hoover, Steven De Gryze, Steven Seguin, Theodore Vasiloudis, Thomas
Expand Down Expand Up @@ -1542,7 +1558,7 @@ Enhancements
in their constructor. By `Manoj Kumar`_.

- Added decision function for :class:`multiclass.OneVsOneClassifier`
By `Raghav R V`_ and :user:`Kyle Beauchamp <kyleabeauchamp>`.
By `Raghav RV`_ and :user:`Kyle Beauchamp <kyleabeauchamp>`.

- :func:`neighbors.kneighbors_graph` and :func:`radius_neighbors_graph`
support non-Euclidean metrics. By `Manoj Kumar`_
Expand Down Expand Up @@ -1789,7 +1805,7 @@ API changes summary

- From now onwards, all estimators will uniformly raise ``NotFittedError``
(:class:`utils.validation.NotFittedError`), when any of the ``predict``
like methods are called before the model is fit. By `Raghav R V`_.
like methods are called before the model is fit. By `Raghav RV`_.

- Input data validation was refactored for more consistent input
validation. The ``check_arrays`` function was replaced by ``check_array``
Expand Down Expand Up @@ -4751,7 +4767,7 @@ David Huard, Dave Morrill, Ed Schofield, Travis Oliphant, Pearu Peterson.

.. _Noel Dawe: https://github.com/ndawe

.. _Raghav R V: https://github.com/raghavrv
.. _Raghav RV: https://github.com/raghavrv

.. _Tom Dupre la Tour: https://github.com/TomDLT

Expand Down
2 changes: 1 addition & 1 deletion sklearn/model_selection/_split.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# Author: Alexandre Gramfort <[email protected]>,
# Gael Varoquaux <[email protected]>,
# Olivier Grisel <[email protected]>
# Raghav R V <[email protected]>
# Raghav RV <[email protected]>
# License: BSD 3 clause


Expand Down

0 comments on commit 680a5b8

Please sign in to comment.